Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varien_ - DOC block update (1) #703

Merged
merged 6 commits into from
Jun 9, 2020
Merged

Varien_ - DOC block update (1) #703

merged 6 commits into from
Jun 9, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jun 2, 2019

  • Varien_Data_
  • Varien_Event_
  • Varien_Object

Big part for PHPStorm/phpstan :)

- Varien_Data_
- Varien_Event_
- Varien_Object
@kkrieger85 kkrieger85 added the review needed Problem should be verified label Jun 3, 2019
kkrieger85
kkrieger85 previously approved these changes Jun 3, 2019
lib/Varien/Data/Form/Element/Fieldset.php Outdated Show resolved Hide resolved
- reverts change from review
- reverts some code style changes
- adds/fixed some methods/return types
@sreichel sreichel requested a review from Flyingmana June 5, 2019 13:33
@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Jun 16, 2019
@sreichel sreichel removed the review needed Problem should be verified label Jun 23, 2019
lib/Varien/Data/Collection/Db.php Outdated Show resolved Hide resolved
lib/Varien/Data/Tree/Db.php Show resolved Hide resolved
@sreichel sreichel added the hold label May 9, 2020
@sreichel sreichel requested review from tmotyl and kkrieger85 May 9, 2020 21:39
@sreichel sreichel removed the hold label May 9, 2020
tmotyl
tmotyl previously approved these changes May 9, 2020
@tmotyl
Copy link
Contributor

tmotyl commented May 9, 2020

please resolve the conflict

tmotyl
tmotyl previously approved these changes May 9, 2020
This was referenced May 22, 2020
@sreichel sreichel added the Component: lib/Varien Relates to lib/Varien label Jun 4, 2020
colinmollenhour
colinmollenhour previously approved these changes Jun 9, 2020
@colinmollenhour colinmollenhour dismissed stale reviews from tmotyl and themself via 750c2f5 June 9, 2020 20:36
@colinmollenhour colinmollenhour merged commit 3c01888 into OpenMage:1.9.4.x Jun 9, 2020
@sreichel sreichel deleted the cleanup/docs/Varien-1 branch June 9, 2020 21:43
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: lib/Varien Relates to lib/Varien
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants