Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage_CurrencySymbol - DOC block update #708

Merged
merged 3 commits into from
May 14, 2020
Merged

Mage_CurrencySymbol - DOC block update #708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3945b53
Mage CurrencySymbol - DOC block update
sreichel Jun 4, 2019
ab120ac
Mini update
sreichel Jun 23, 2019
8d91ad0
Reverted added property
sreichel Jun 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/code/core/Mage/CurrencySymbol/Block/Adminhtml/System/Currencysymbol.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@
*/
class Mage_Currencysymbol_Block_Adminhtml_System_Currencysymbol extends Mage_Adminhtml_Block_Widget_Form
{
/**
* @var string
*/
private $_blockGroup;
sreichel marked this conversation as resolved.
Show resolved Hide resolved

/**
* @var string
*/
private $_controller;

/**
* Constructor. Initialization required variables for class instance.
*/
Expand Down Expand Up @@ -77,7 +87,7 @@ public function getHeader()
*/
public function getSaveButtonHtml()
{
/** @var $block Mage_Core_Block_Abstract */
/** @var Mage_Core_Block_Abstract $block */
$block = $this->getLayout()->createBlock('adminhtml/widget_button');
$block->setData(array(
'label' => Mage::helper('currencysymbol')->__('Save Currency Symbols'),
Expand Down
2 changes: 1 addition & 1 deletion app/code/core/Mage/CurrencySymbol/Model/Observer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class Mage_CurrencySymbol_Model_Observer
* Generate options for currency displaying with custom currency symbol
*
* @param Varien_Event_Observer $observer
* @return Mage_CurrencySymbol_Model__Observer
* @return $this
*/
public function currencyDisplayOptions(Varien_Event_Observer $observer)
{
Expand Down
10 changes: 6 additions & 4 deletions app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
* @category Mage
* @package Mage_CurrencySymbol
* @author Magento Core Team <core@magentocommerce.com>
*
* @method $this resetValues()
sreichel marked this conversation as resolved.
Show resolved Hide resolved
*/
class Mage_CurrencySymbol_Model_System_Currencysymbol
{
Expand Down Expand Up @@ -126,7 +128,7 @@ public function getCurrencySymbolsData()
Mage::getStoreConfig(self::XML_PATH_ALLOWED_CURRENCIES, null)
);

/* @var $storeModel Mage_Adminhtml_Model_System_Store */
/* @var Mage_Adminhtml_Model_System_Store $storeModel */
$storeModel = Mage::getSingleton('adminhtml/system_store');
foreach ($storeModel->getWebsiteCollection() as $website) {
$websiteShow = false;
Expand Down Expand Up @@ -158,7 +160,7 @@ public function getCurrencySymbolsData()

$currentSymbols = $this->_unserializeStoreConfig(self::XML_PATH_CUSTOM_CURRENCY_SYMBOL);

/** @var $locale Mage_Core_Model_Locale */
/** @var Mage_Core_Model_Locale $locale */
$locale = Mage::app()->getLocale();
foreach ($allowedCurrencies as $code) {
if (!$symbol = $locale->getTranslation($code, 'currencysymbol')) {
Expand Down Expand Up @@ -191,7 +193,7 @@ public function getCurrencySymbolsData()
/**
* Saves currency symbol to config
*
* @param $symbols array
* @param array $symbols
* @return $this
*/
public function setCurrencySymbolsData($symbols=array())
Expand Down Expand Up @@ -251,7 +253,7 @@ public function getCurrencySymbol($code)
/**
* Clear translate cache
*
* @return Saas_Translate_Helper_Data
* @return $this
*/
public function clearCache()
{
Expand Down