[FIX] return annotation of getScript in helper core/js #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeSaferite
added a commit
that referenced
this pull request
Jan 14, 2015
[FIX] return annotation of getScript in helper core/js
|
sorry, but this change was in an official magento update or patch? i thought this repo is meant to be an exact copy of the Magento cc @LeeSaferite Best regards, |
|
Indeed! See OpenMage/magento-lts#8. |
|
OpenMage/magento-lts it is a fork that accepts fixes, but OpenMage/magento-mirror should be an exact copy of magento, with bugs :) |
|
do i miss something? i think is the other way arround :) |
|
You are 100% correct. The pull request was merged in error and has been reverted. |
|
If there were a way for me to disable pull requests on this repo I would. |
|
thanks you both best regards, |
|
you still could do a force push, to revoke the merge completely from history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.