Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment of PBS docking base not checking PBSEggs of same(type/category) for quantity limits #448

Closed
MikeJeffers opened this issue Nov 22, 2021 · 0 comments · Fixed by #449
Closed

Deployment of PBS docking base not checking PBSEggs of same(type/category) for quantity limits #448

MikeJeffers opened this issue Nov 22, 2021 · 0 comments · Fixed by #449
Assignees
@MikeJeffers
Labels
bug Something isn't working Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation Gamma This issue or PR has to do with Gamma Priority: High This ticket needs to be completed asap

Comments

@MikeJeffers
Copy link

While the range check does explicitly check egg conditions, the quantity checks do not!
@MikeJeffers MikeJeffers added bug Something isn't working Gamma This issue or PR has to do with Gamma Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation Priority: High This ticket needs to be completed asap labels Nov 22, 2021
@MikeJeffers MikeJeffers self-assigned this Nov 22, 2021
@MikeJeffers MikeJeffers mentioned this issue Nov 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeJeffers MikeJeffers

Labels
bug Something isn't working Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation Gamma This issue or PR has to do with Gamma Priority: High This ticket needs to be completed asap
Projects
Game Server
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PBS base limit check fixes OpenPerpetuum/PerpetuumServer
1 participant
@MikeJeffers