Code changes to with Aruba VIA client #150
Conversation
|
With the commit as is, there is no chance that it can get merged. It is lacking a proper commit message to explain these changes (in detail). More problematic is the sprinkling of HP copyright messages across all files, and changing of the resource.rc names - you can do that, as means of a fork, but we can not merge it back. So if you want to do a useful PR, isolate the changes that can go upstream (no changing of TAP_WIN_SUFFIX, VER_LEGALCOPYRIGHT_STR, VER_COMPANYNAME_STR, etc) and resubmit with a good commit message that explains what is changed and why. |
| #define VER_ORIGINALFILENAME_STR PRODUCT_TAP_WIN_COMPONENT_ID ".sys" | ||
| #define VER_LEGALCOPYRIGHT_YEARS "2003-2018" | ||
| #define VER_LEGALCOPYRIGHT_STR "OpenVPN Technologies, Inc." | ||
| #define VER_LEGALCOPYRIGHT_STR "Copyright 2022 Hewlett Packard Enterprise Development LP." |
There was a problem hiding this comment.
Removing the original Copyright is probably not even legal for a GPL program.
| { | ||
| bIsDestinationSame = (src->m_ARP_IP_Destination & ip_netmask) == ip_network ? TRUE : FALSE; | ||
| } | ||
| #endif //ARUBA_SPECIFIC |
There was a problem hiding this comment.
This logic might be useful but it needs better naming and better explaination.
Modified the device name and added condition to work Aruba VIA client.