Allowing to use the configured MTU and to work with HPE Aruba Client #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwabe
reviewed
Jul 28, 2023
| #define VER_ORIGINALFILENAME_STR PRODUCT_TAP_WIN_COMPONENT_ID ".sys" | ||
| #define VER_LEGALCOPYRIGHT_YEARS "2003-2018" | ||
| #define VER_LEGALCOPYRIGHT_STR "OpenVPN Technologies, Inc." | ||
| #define VER_LEGALCOPYRIGHT_STR "Copyright 2022 Hewlett Packard Enterprise Development LP." |
There was a problem hiding this comment.
Is this a joke? You cannot claim copyright on something that you don't own. That is a serious copyright violation if you actually ship the driver like that in your products.
|
You already got feedback to this approach in your previous PR #150. That feedback still applies. |
|
It seems there is a bugfix related to MTU handling in here - this should go into its own PR, unrelated to the HPE/Aruba changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bIsDestinationSameto TRUE to work with HPE Aruba Client.bIsDestinationSamebased on which client it is loaded by.bIsDestinationSamerelated changes are conditionally compiled based on the macroARUBA_SPECIFICvalue.