Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Issue: Planned breaking changes for new major (5.0) #2961

Closed
Amxx opened this issue Nov 11, 2021 · 2 comments
Closed

Meta Issue: Planned breaking changes for new major (5.0) #2961

Amxx opened this issue Nov 11, 2021 · 2 comments
Labels
breaking change Changes that break backwards compatibility of the public API.

Comments

@Amxx
Copy link
Collaborator

Amxx commented Nov 11, 2021

Here is a list of breaking changes that we would like to include in the next major release. Timming for this release is not yet known.

@frangio
Copy link
Contributor

frangio commented Sep 16, 2022

We should break this up into multiple issues except those that should be implemented and reviewed together.

We might just need the milestone to track these items instead of the meta issue.

@frangio
Copy link
Contributor

frangio commented Jan 4, 2023

Most of these items have their own issues by now so I will close this issue.

The missing ones are:

  • Make some contract libraries (ERC1967)

We can't make ERC1967Upgrade into a library because it needs to emit events. I don't know if there are others like this.

  • Make some storage values constant (see 712)

Not sure exactly what this means. We do have #2538 and #2638, none of those are about EIP712.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Development

No branches or pull requests

2 participants