Trim Async suffix (#14407)

Co-authored-by: Vincent Jacquet <vjacquet@wmcsoft.com>
OrchardCMS · Sep 29, 2023 · d743d5f · d743d5f
1 parent 9a76299
commit d743d5f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultShapeFactory.cs b/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultShapeFactory.cs
@@ -38,7 +38,7 @@ public override bool TryInvokeMember(InvokeMemberBinder binder, object[] args, o
 
             if (binderName.EndsWith("Async", StringComparison.Ordinal))
             {
-                binderName = binder.Name[^"Async".Length..];
+                binderName = binder.Name[..^"Async".Length];
             }
 
             result = ShapeFactoryExtensions

diff --git a/test/OrchardCore.Tests/DisplayManagement/ShapeFactoryTests.cs b/test/OrchardCore.Tests/DisplayManagement/ShapeFactoryTests.cs
@@ -61,6 +61,15 @@ public async Task CallSyntax()
             Assert.Equal("Foo", metadata.Type);
         }
 
+        [Fact]
+        public async Task CallSyntaxAsync()
+        {
+            dynamic factory = _serviceProvider.GetService<IShapeFactory>();
+            var foo = await factory.FooAsync();
+            ShapeMetadata metadata = foo.Metadata;
+            Assert.Equal("Foo", metadata.Type);
+        }
+
         [Fact]
         public async Task CallInitializer()
         {