Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy field editors should work with published version #10288

Closed
tropcicstefan opened this issue Sep 16, 2021 · 7 comments
Closed

Taxonomy field editors should work with published version #10288

tropcicstefan opened this issue Sep 16, 2021 · 7 comments

Comments

@tropcicstefan
Copy link
Contributor

tropcicstefan commented Sep 16, 2021

Describe the bug

In admin UI in content item editors with taxonomy field, user can select taxonomy term even though that version of taxonomy isn't published yet.
So if taxonomy is in draft should it be available to be picked?
If an answer to the previous question is yes, then what is the reason for taxonomy to be draftable and then this code in TaxonomyContentsAdminList is bugged.

To Reproduce

Create taxonomy add some terms, and publish taxonomy, then add additional term but don't publish the taxonomy.

Expected behavior

I see taxonomy as a backbone of the site so if something is in preparation, to be decided, changed whatever, it shouldn't be available throughout whole site.

@deanmarcussen
Copy link
Member

Can you just change the taxonomy content type and remove draftable?

@tropcicstefan tropcicstefan changed the title Taxonomy field editors should work with latest version Taxonomy field editors should work with published version Sep 17, 2021
@tropcicstefan
Copy link
Contributor Author

I could change it through UI, but then versioning is lost, because of the way AdminController works.
For my app I built custom driver so it's not like I need this change, but just thought there are discrepancies between field and admin list filter. And in logic if something is drafted vs published.

Although that line of thinking could solve #7054

In the end it's architectural decision

@sebastienros
Copy link
Member

I am confused about the issue. @deanmarcussen seems to think it's about the admin filter (based on your link).
Can you explain what behavior your are seeing and are not expecting?

In admin UI in content item editors with taxonomy field, user can select taxonomy term even though that version of taxonomy isn't published yet.

That is not a bug to me, that was intentionally designed this way. And I don't see what issue there is with it, hence why I am asking you to describe the expected behavior.

@sebastienros sebastienros added this to the backlog milestone Sep 23, 2021
@tropcicstefan
Copy link
Contributor Author

Blog recipe
added food category to taxonomy
image

didn't click publish on taxonomy
image

go to blog post, there is food
image

look into taxonomy filter on content items list, there is no food
image

so the question is, is drafted taxonomy valid (can be used throughout the system) or not?
if yes then filters should have those terms, if not then field editor shoudn't show those terms.

@sebastienros
Copy link
Member

filters should have those terms

yes

Then should we allow a published content item have a draft-only field? I think we can do too, but querying should take that into account and the behavior configurable in the queries (not returning a content item for instance on the front-end).

Copy link
Contributor

It seems that this issue didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please reply.

@github-actions github-actions bot added the stale label May 24, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Closing this issue because it didn't receive further feedback from the author for very long. If you think this is still relevant, feel free to reopen it with the requested details.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants