Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL & Gatsby 3, 4 - not working #10781

Closed
MikeKry opened this issue Nov 30, 2021 · 5 comments
Closed

GraphQL & Gatsby 3, 4 - not working #10781

MikeKry opened this issue Nov 30, 2021 · 5 comments

Comments

@MikeKry
Copy link
Contributor

MikeKry commented Nov 30, 2021

OrchardCore does not work with new gatsby versions.

It seems that it is caused by different data type structures. I have tested update of GraphQL .NET update and it helped.

I have also created a PR that resolves this issue.

stacktrace from error here:

Missing onError handler for invocation 'building-schema', error was 'RangeError: Maximum call stack size exceeded'. Stacktrace was 'RangeError: Maximum call stack size exceeded
at getInputObjectTypeDefinitionNode (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:49:3)
at InputTypeComposer.getType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\InputTypeComposer.js:436:81)
at ListComposer.getType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\ListComposer.js:22:49)
at InputTypeComposer.getFieldType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\InputTypeComposer.js:315:42)
at D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:349:101
at Array.map ()
at getInputValueDefinitionNodes (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:336:21)
at getInputObjectTypeDefinitionNode (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:57:13)
at InputTypeComposer.getType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\InputTypeComposer.js:436:81)
at ListComposer.getType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\ListComposer.js:22:49)
at InputTypeComposer.getFieldType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\InputTypeComposer.js:315:42)
at D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:349:101
at Array.map ()
at getInputValueDefinitionNodes (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:336:21)
at getInputObjectTypeDefinitionNode (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\utils\definitionNode.js:57:13)
at InputTypeComposer.getType (D:\project\project.Gatsby\node_modules\gatsby\node_modules\graphql-compose\lib\InputTypeComposer.js:436:81)'

@sebastienros sebastienros added this to the 1.x milestone Dec 2, 2021
@MikeKry
Copy link
Contributor Author

MikeKry commented Feb 19, 2022

adding ref. to open PR #9087

@Piedone
Copy link
Member

Piedone commented May 17, 2024

We've updated GraphQL many times since this. Can you tell if this is still an issue?

@hishamco
Copy link
Member

Ya, I will never remember the massive change that I started on GraphQL, then completed in an elegant way by @hyzx86. I think this should be fixed in the latest bits

@MikeKry
Copy link
Contributor Author

MikeKry commented May 18, 2024

@Piedone

No, sorry I forgot to close this one :)

This is fixed by #9087 that we had done long time ago, but it took kinda long to merge so I forgot because I was locally already using version containing my last commit.

That said - it is working in OrchardCore 1.4 to 1.8. But as @hishamco mentioned, there was another update of GraphQL done (#15284) and I noticed that there were multiple bug reports. That is reason why I did not switch to latest version of OrchardCore yet and I do not know if it works on new version.

But I think we can close it for now and when I will eventually update locally, then I can reopen if this problem occurs again?

@Piedone
Copy link
Member

Piedone commented May 18, 2024

Yep, sure, thank you.

@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants