Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultContentManager as override able #11655

Closed
hyzx86 opened this issue May 7, 2022 · 6 comments
Closed

Make DefaultContentManager as override able #11655

hyzx86 opened this issue May 7, 2022 · 6 comments

Comments

@hyzx86
Copy link
Contributor

hyzx86 commented May 7, 2022

I wanted to rewrite The DeaultContentManager, but there are some problems :

  1. Data is a property of the Internal modifier that prevents me from accessing this property in other assemblies
  2. Define all the methods in DefaultContentManager as virtual methods

image

@hishamco
Copy link
Member

hishamco commented May 7, 2022

What sort of modifications you may change in the default implementation?

@ns8482e
Copy link
Contributor

ns8482e commented May 7, 2022

@hyzx86 why you would rewrite content manager?

@ns8482e
Copy link
Contributor

ns8482e commented May 7, 2022

There are other framework features available for CRUD of entity other than content item

@hyzx86
Copy link
Contributor Author

hyzx86 commented May 7, 2022

Here I have create a PR ,but it still at there many days
#11532

Here I created a PR, but it's still there for many days
I'm going to rewrite the bulk import function,
And some error event interception
OC's PR audit was so slow that I could only quickly implement these changes by modifying the code.
However, these Settings prevented me from overwriting some features

@hyzx86
Copy link
Contributor Author

hyzx86 commented May 7, 2022

In this Issue it is mentioned to change the way the Handler executes, such as session.CancelAsync() when the Handler reports an error.
#11643

@hyzx86
Copy link
Contributor Author

hyzx86 commented May 7, 2022

It seems to have been solved by internal invocation😂

image

@hyzx86 hyzx86 closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants