sending email with invalid smtp certificate

[sergeor]

Mailkit supports sending email when the server's smtp certificate is invalid. Maybe this function should be integrated into OrchardCore.

smtp.ServerCertificateValidationCallback = (mysender, certificate, chain, sslPolicyErrors) => { return true; }; smtp.CheckCertificateRevocation = false;

[hishamco]

It's already there

OrchardCore/src/OrchardCore/OrchardCore.Email.Core/Services/SmtpService.cs

Lines 242 to 269 in d312e24

	private bool CertificateValidationCallback(object sender, X509Certificate certificate, X509Chain chain, SslPolicyErrors sslPolicyErrors)
	{
	const string LogErrorMessage = "SMTP Server's certificate {CertificateSubject} issued by {CertificateIssuer} " +
	"with thumbprint {CertificateThumbprint} and expiration date {CertificateExpirationDate} " +
	"is considered invalid with {SslPolicyErrors} policy errors";
	if (sslPolicyErrors == SslPolicyErrors.None)
	{
	return true;
	}
	_logger.LogError(LogErrorMessage,
	certificate.Subject,
	certificate.Issuer,
	certificate.GetCertHashString(),
	certificate.GetExpirationDateString(),
	sslPolicyErrors);
	if (sslPolicyErrors.HasFlag(SslPolicyErrors.RemoteCertificateChainErrors) && chain?.ChainStatus != null)
	{
	foreach (var chainStatus in chain.ChainStatus)
	{
	_logger.LogError("Status: {Status} - {StatusInformation}", chainStatus.Status, chainStatus.StatusInformation);
	}
	}
	return false;
	}

[hishamco]

Maybe the current issue is you can't send the email when there's error

[sergeor]

Yes, but I would like to have the choice (with a check box from the mail server settings in the admin area) to be able to bypass the invalid or self-signed certificate.
The code that i read is just check if certificate is valid and if not return false and stop send.

[hishamco]

Check my related PR

[hishamco]

I reopen this will be closed automatically once the PR is merged