Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use IHttpClientFactory in MediaStep to create instance of HttpClient #15346

Closed
MikeAlhayek opened this issue Feb 16, 2024 · 0 comments · Fixed by #15350
Closed

use IHttpClientFactory in MediaStep to create instance of HttpClient #15346

MikeAlhayek opened this issue Feb 16, 2024 · 0 comments · Fixed by #15350
Labels
bug 🐛
Milestone
2.0

Comments

@MikeAlhayek
Copy link
Member

The MediaStep creates a static HttpClient instance. I think we should be using IHttpFactory there instead,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Use IHttpClientFactory.CreateClient() instead of static HttpClient OrchardCMS/OrchardCore
1 participant
@MikeAlhayek