Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies or checks on disabling features. #6179

Closed
DjTeo opened this issue May 13, 2020 · 5 comments
Closed

Missing dependencies or checks on disabling features. #6179

DjTeo opened this issue May 13, 2020 · 5 comments
Labels
Milestone

Comments

@DjTeo
Copy link

DjTeo commented May 13, 2020

Default headless recipe if I disable 'Roles' feature or 'Users' Feature (maybe and others), Orchard throw an unhandled exception:

InvalidOperationException: Unable to resolve service for type 'Microsoft.AspNetCore.Identity.IRoleStore1[OrchardCore.Security.IRole]' while attempting to activate 'Microsoft.AspNetCore.Identity.RoleManager1[OrchardCore.Security.IRole]'

Maybe remove the ability to disable core features.
I don't know how to enable it again so I can continue to work on my site.

I want to propose an Idea with this in mind. When a module fails to load and throws an exception have the ability to disable that module.

@hishamco
Copy link
Member

It make sense, if the one module depends on others

@DjTeo
Copy link
Author

DjTeo commented May 13, 2020

It make sense, if the one module depends on others

Shouldn't prevent you from disabling it or disable others modules too?

@sebastienros
Copy link
Member

Looks like a module depends on it. We need to understand what component is failing in this case, the stack trace is too small here.

@sebastienros
Copy link
Member

And if we don't want to depend on a specific module, at least have a default implementation that does nothing (for IRoleService in this case)

@sebastienros sebastienros added this to the 1.0.x milestone May 21, 2020
@Piedone
Copy link
Member

Piedone commented May 5, 2024

This doesn't seem to be still a bug, so I'll close now. Please reopen if you still experience this.

@Piedone Piedone closed this as completed May 5, 2024
@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants