Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.5 #12635

Merged
merged 8 commits into from
Nov 4, 2022
Merged

release/1.5 #12635

merged 8 commits into from
Nov 4, 2022

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Oct 13, 2022

Closes #12680

@Skrypt
Copy link
Contributor

Skrypt commented Oct 24, 2022

@rprouse @sebastienros Any idea why the DNF license cannot be found on the OC project?

@rprouse
Copy link

rprouse commented Oct 24, 2022

@Skrypt The .NET Foundation uses either an assignment model or a contribution model for on-boarding new projects. Under the assignment model, a project transfers ownership of the copyright to the .NET Foundation. Under the contribution model, a project retains ownership of the copyright, but grants the .NET Foundation a broad license to the project's code and other intellectual property.

I would need to check, but my guess is that OC is under the contribution model.

@hishamco
Copy link
Member

Does the release align with .NET 7.0 or not?

@ns8482e
Copy link
Contributor

ns8482e commented Oct 24, 2022

Does the release align with .NET 7.0 or not?

1.5 is still on .NET 6

@hishamco
Copy link
Member

1.5 is still on .NET 6

Yep, I thought Seb waiting for upcoming major release

@Skrypt
Copy link
Contributor

Skrypt commented Oct 24, 2022

There is a PR for .NET 7.0 and it is not planned for this milestone. Though, we need to understand what is happening with the licence/cla from DNF. Since last week every new PR has had issues with recognizing the license/cla agreement that we as contributors to the project have signed at some point in time. So, while I'm not an admin of this repository; I think we will need to wait on @sebastienros. I also added @rprouse to the discussion so that we be able to at least get a lead on what the issue might possibly be. I'm sorry in advance to bother you both about this, I just have no idea what is happening exactly. So far, @ns8482e tested to know if there was a licence associated with this repository and we found none by testing with these url:

https://cla.dotnetfoundation.org/OrchardCMS/OrchardCore?pullRequest=12635
https://cla.dotnetfoundation.org/OrchardCMS/OrchardCore?pullRequest=12681

Also, as you can see here on an older PR it was working:

image

https://cla.dotnetfoundation.org/OrchardCMS/OrchardCore?pullRequest=12671

Though if we test it, or if @ns8482e makes any new commit to this PR it might fail to find the license.

@Skrypt Skrypt merged commit 5fc8f0b into main Nov 4, 2022
@Skrypt Skrypt deleted the release/1.5 branch November 4, 2022 18:42
@Skrypt Skrypt restored the release/1.5 branch November 4, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.5
6 participants