Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graphql api with parameters #15529

Merged
merged 24 commits into from
Mar 21, 2024
Merged

Fix graphql api with parameters #15529

merged 24 commits into from
Mar 21, 2024

Conversation

hyzx86
Copy link
Contributor

@hyzx86 hyzx86 commented Mar 17, 2024

Fixed #15527

@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 18, 2024

Hi @MikeAlhayek ，could you please review this PR?
This is a very serious problem for me ，Thanks!

@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 18, 2024

@MikeAlhayek All done

@hyzx86 hyzx86 requested a review from MikeAlhayek March 18, 2024 18:27
@hyzx86 hyzx86 requested a review from MikeAlhayek March 19, 2024 01:03
@hyzx86 hyzx86 requested a review from MikeAlhayek March 19, 2024 03:22
@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 21, 2024 •
edited
Loading

Hi @Piedone， can you please review this PR？Thanks!

@Piedone
Copy link
Member

Piedone commented Mar 21, 2024

If Mike is OK with this then I'm OK with it too, or is there anything specific why you think it would be useful for me to review as well?

@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 21, 2024

If Mike is OK with this then I'm OK with it too, or is there anything specific why you think it would be useful for me to review as well?

No, I was wondering does a PR need at least two approvals to pass?

@hyzx86 hyzx86 requested a review from MikeAlhayek March 21, 2024 14:59
@Piedone
Copy link
Member

Piedone commented Mar 21, 2024

Nope, one is enough :).

@hishamco
Copy link
Member

@MikeAlhayek please mention this PR #12845 in the triage meeting today, I might unable to attend today

@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 21, 2024

@hishamco Thank you. Are you feeling better about your cold? Take care of yourself!

@hishamco
Copy link
Member

I'm better now, thanks for asking Tony

@MikeAlhayek MikeAlhayek merged commit 5d67de4 into OrchardCMS:main Mar 21, 2024
4 checks passed
@hishamco
Copy link
Member

Thanks for your contribution Tony

This was referenced Apr 1, 2024
Closed
Open
@hyzx86 hyzx86 deleted the fix_graphql_api_with_parameters branch June 13, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@Jetski5822 Jetski5822 Awaiting requested review from Jetski5822

@carlwoodhouse carlwoodhouse Awaiting requested review from carlwoodhouse

@MikeAlhayek MikeAlhayek Awaiting requested review from MikeAlhayek

Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grpahql editor query error
5 participants
@hyzx86 @Piedone @hishamco @sebastienros @MikeAlhayek