Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set listpart property in listpartviewmodel #15560

Merged

Conversation

aliamiras
Copy link
Contributor

Set list part when displaying the shape.
Extend console_log to support ContentPart.
closes #15558

@aliamiras
Copy link
Contributor Author

aliamiras commented Mar 21, 2024 via email

@hishamco
Copy link
Member

@MichaelPetrinolis your review please

@hishamco
Copy link
Member

@all-contributors please add @aliamiras for code.

Copy link
Contributor

@hishamco

I've put up a pull request to add @aliamiras! 🎉

@hishamco
Copy link
Member

@Piedone why the bot create a new PR instead of adding an entry in the same PR?

@Piedone
Copy link
Member

Piedone commented Mar 21, 2024

You have to ask their developers about the decision behind this, but that's the only way it can work. See https://allcontributors.org/docs/en/bot/configuration.

@hishamco hishamco merged commit d693ab5 into OrchardCMS:main Mar 21, 2024
4 checks passed
@hishamco
Copy link
Member

Thank you for your contributions, and congrats on your first one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListPart DisplayDriver does not set ListPart property on ListPartViewModel
5 participants