Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fluid.Core, YesSQL, and Shortcodes #16470

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Update Fluid.Core, YesSQL, and Shortcodes #16470

merged 11 commits into from
Jul 23, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@MikeAlhayek
Copy link
Member Author

This PR is going to have to wait for sebastienros/shortcodes#34 then a new release of Shortcodes package.

@Piedone Piedone marked this pull request as draft July 22, 2024 19:06
@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

Converted to draft until then.

@MikeAlhayek MikeAlhayek mentioned this pull request Jul 22, 2024
Merged
@MikeAlhayek MikeAlhayek changed the title Update Fluid.Core Update Fluid.Core, YesSQL, and Shortcodes Jul 22, 2024
@Piedone Piedone mentioned this pull request Jul 23, 2024
Closed
@MikeAlhayek MikeAlhayek marked this pull request as ready for review July 23, 2024 16:48
@MikeAlhayek
Copy link
Member Author

@lahma can you please review this PR?

lahma
lahma approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, there might be some performance improvement opportunities later, but not related to this PR 👍🏻

@MikeAlhayek MikeAlhayek merged commit 162453d into main Jul 23, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/update-fluid branch July 23, 2024 17:38
This was referenced Aug 1, 2024
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeAlhayek @Piedone @lahma