-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dynamic cache tag helper #6737
Conversation
Still I see a value of using |
Here the singularity is that the mvc So i suggest And also because our tag helper uses Update: E.g. for script and style tag helpers we use a bridge between razor and liquid, it's good for maintainability as they use the same code. So just to say that this is not the case for caching tags, but at least here nothing to do on liquid side ;) |
It's kinda wordy? But so is @hishamco The idea is to not have to configure anything special in |
Three years!! that's too long ;) the tag prefix will not change the name, we can keep the tag name as it was, so no breaking changes. It just a token that can differentiate our tag helpers from other 3rd-party once and avoid us from thinking about new names whenever create a tag helper and AspNetCore has similar one. It is something like old WebForms controls: |
Maybe I am misunderstanding the prefix suggestion. It is something the user has to add to their So doesn't prevent the collision, just provides another way of managing them. If I have misunderstood, show an example? |
Exactly!!
Why?!! if we prefix our tag helpers in all assemblies, no collision will happen, because we should write |
Fixes #6548