Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: customize general outputs #390

Open
Echoring opened this issue Aug 27, 2024 · 1 comment
Open

raidboss: customize general outputs #390

Echoring opened this issue Aug 27, 2024 · 1 comment
Labels
enhancement New feature or change to existing functionality needs-review Awaiting review

Comments

@Echoring
Copy link
Collaborator

Feature(s) Requested

General output from resource/output.ts are widely used in raidboss alert text. Although it is possible to directly modify every trigger output text, it can be annoying when you have trouble reading a widely used general output.
For example, I have some trouble to quickly respond to NW/SW/NE/SE style direction abbr. I have to check all triggers that include these direction and edit them.
Is it possible to add a tab in cactbot config panel to allow user custom general outputs? I believe this will also benefit left/west, right/east preference issue.

@Echoring Echoring added enhancement New feature or change to existing functionality needs-review Awaiting review labels Aug 27, 2024
@wexxlee
Copy link
Collaborator

wexxlee commented Aug 29, 2024

I'm wondering if this might be something that would make more sense to support in user config files but not actually through the config UI?

I think the challenge with the UI is that we don't really expose when a trigger is using something from Outputs - we only display the actual value and let the user edit it. So a user could go in and try to override Outputs values in the config UI without necessarily understanding how that change will propagate and where it will be used. (I'm just envisioning issues getting opened and ACT discord support requests with users asking why 'X' trigger doesn't show their new 'Y' override text, without understanding that perhaps that trigger doesn't use Outputs for Reasons, or whatever.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or change to existing functionality needs-review Awaiting review
Projects
None yet
Development

No branches or pull requests

2 participants