Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Extractors: Status code on failure #209

Closed
AbrJA opened this issue Jul 29, 2024 · 1 comment · Fixed by #214
Closed

Request Extractors: Status code on failure #209

AbrJA opened this issue Jul 29, 2024 · 1 comment · Fixed by #214

Comments

@AbrJA
Copy link
Sponsor

AbrJA commented Jul 29, 2024

Hi @ndortega, I hope you are doing well,

The last features you added are really nice, good job man.

I have just a small question, if the extractor or the validator fails currently it returns a 500 status code (Internal Server Error), wouldn't it be better to return a 400 status code (Bad request)?

Let me know your thoughts,

Abraham JA

@ndortega
Copy link
Member

ndortega commented Aug 7, 2024

Hi @AbrJA,

Absolutely, that makes a lot more sense to throw a 400 in that case.

@ndortega ndortega linked a pull request Sep 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants