Minor bug in CMakeLists.txt

[deadlocklogic]

pcre2/CMakeLists.txt

Line 778 in 5271b53

ELSE(BUILD_STATIC_LIBS)

Should be BUILD_SHARED_LIBS, because it won't make sense this way.
Thanks.

[deadlocklogic]

Same goes for:

pcre2/CMakeLists.txt

Line 841 in 5271b53

ELSE(BUILD_STATIC_LIBS)

pcre2/CMakeLists.txt

Line 903 in 5271b53

ELSE(BUILD_STATIC_LIBS)

pcre2/CMakeLists.txt

Line 1103 in 5271b53

ELSE(BUILD_STATIC_LIBS)

[deadlocklogic]

Any chance to replace INCLUDE_DIRECTORIES with the newer/better TARGET_INCLUDE_DIRECTORIES in cmake?

[PhilipHazel]

Please take a look at issues #104 and #115. There is a proposal for a totally revised up-to-date new CMake config, but I do not know if this is progressing. I am loath to make any more changes to CMakeLists.txt at the moment. I rely entirely on the CMake community for the CMake config.

[deadlocklogic]

Ok no worries, I was just trying to point out obvious bugs (maybe cause of copy pasting, and happens to all of us).
I will check the links for sure.
Thanks.

If you want I can submit a PR fixing these minor issues by the way.
Just to point out this is trivially a bug:

pcre2/CMakeLists.txt

Lines 775 to 781 in 5271b53

	IF(BUILD_STATIC_LIBS)
	ADD_LIBRARY(pcre2-8 ALIAS pcre2-8-static)
	ADD_LIBRARY(pcre2-posix ALIAS pcre2-posix-static)
	ELSE(BUILD_STATIC_LIBS)
	ADD_LIBRARY(pcre2-8 ALIAS pcre2-8-shared)
	ADD_LIBRARY(pcre2-posix ALIAS pcre2-posix-shared)
	ENDIF(BUILD_STATIC_LIBS)

No matter one's CMake proficiency. Maybe all the folks are statically linking anyway!
And thanks again for your efforts.

[wrowe]

Yes, this is a problem, the problematic lines (surely cut n' paste issues) all stem from this PR 2410fbe

I'd ignore starting from scratch in issue #115 and follow the basic idea (simplify / streamline where ever possible) and go ahead, please do submit a PR, feel free to @ mention me and I'll even chip in a review. I noted this patch was full of unfinished changes, notably;

2410fbe#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR684-R690

It does appear the accepted and merged commit was never really tested.