Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple recent changes made to pcre2.h.in without updating pcre2.h.generic #205

Closed
saurik opened this issue Feb 8, 2023 · 2 comments
Closed

Comments

@saurik
Copy link

saurik commented Feb 8, 2023

The file src/pcre2.h.in is instantiated as src/pcre2.h.generic with the version numbers filled in, which I guess sadly requires that every change made to pcre2.h is made twice. (I wonder... is there no way to split this header file into just the version number and then the rest of the content? ;P) Recently, while the changes from 303e3bc to pcre2.h.in were included in pcre2.h.generic, the changes from c13d54f, a608946, and c80c633 were not, causing an inconsistent drift in the available definitions.

@PhilipHazel
Copy link
Collaborator

pcre2.h.generic is automatically generated when a release is being prepared using "make dist" (the code is in Makefile.am). This dates back to the days before PCRE2 was on GitHub. pcre2.h itself is generated from pcre2.h.in when somebody runs ./configure. There is a similar issue with config.h.generic, but no double editing is required. These days I do usually remember to run the script that updates the HTML docs when I edit the "man" versions. I will now try to remember to run the relevant Make targets when pcre2.h.in is edited, and do it soon so that everything is in step.

@PhilipHazel
Copy link
Collaborator

I have updated and pushed pcre2.h.generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants