Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show baselines #17

Closed
bertsky opened this issue Nov 13, 2020 · 8 comments
Closed

show baselines #17

bertsky opened this issue Nov 13, 2020 · 8 comments

Comments

@bertsky
Copy link

bertsky commented Nov 13, 2020

Today I was surprised to learn that PageViewer does not visualise TextLine/Baseline.

Wouldn't be much more than checking for line.getBaseline() in DocumentImageView.drawTextlines(), and using a new DrawingHelper.drawMultiline to display it, right?

@chris1010010
Copy link
Contributor

The world is full of surprises...
:-)

@bertsky
Copy link
Author

bertsky commented Nov 13, 2020

The world is full of surprises...
:-)

Sure, but how do I ever get to see a PAGE baseline then? Is Aletheia the only tool that shows them? Or is AletheiaWeb, too?

Also, on my suggestions – assuming I would be able to get the build system for this package – is that the way to go, or am I missing something?

@chris1010010
Copy link
Contributor

Just Aletheia at the moment

@bertsky
Copy link
Author

bertsky commented Nov 13, 2020

Just Aletheia at the moment

I see. Do you happen to know if this works with wine? (It should, you know, since in vino veritas ...)

Also, on my suggestions – assuming I would be able to get the build system for this package – is that the way to go, or am I missing something?

Still thinking about a PR but waiting for your approval/comment.

@chris1010010
Copy link
Contributor

Merged in the baseline code

@bertsky
Copy link
Author

bertsky commented Jan 30, 2021

Merged in the baseline code

Thanks, but 5113c38 is not a merge, it's a copy, modify and paste. I'll have to rebase now. If you had just asked me to split my PR I would have done so (as I said)...

Also, I wonder why you always couple changes of source files with fully regenerated apidoc HTMLs in your commits. This makes it much harder to view them and browse history. If apidoc needs to be in the same repo, please at least commit the HTMLs separately.

@chris1010010
Copy link
Contributor

Ok, yes, it was a manual merge.
Code and JavaDoc are generated. I use a separate code base in SVN. Should move at some point, no time though

@bertsky
Copy link
Author

bertsky commented Jan 30, 2021

Oh, I see – that explains it. But perhaps you could do something like

git add "*.java" && git commit -m "changes"
git add -A && git commit -m "javadoc"

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants