Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TimeTypes #125

Closed
rofinn opened this issue Mar 14, 2018 · 3 comments
Closed

Support TimeTypes #125

rofinn opened this issue Mar 14, 2018 · 3 comments

Comments

@rofinn
Copy link

rofinn commented Mar 14, 2018 •
edited
Loading

It would be nice to support julia base timetypes.

Example)

a = now()
b = a - Dates.Day(1)

hrs = (a - b)u"minute"
@rofinn rofinn changed the title Support automatic conversions from TimeTypes Support TimeTypes Mar 14, 2018
@cstjean
Copy link
Contributor

cstjean commented Oct 12, 2018

@ajkeller34 We need something like this too. I'm happy to make a PR, but a decision needs to be made about what form it will take. Is this desirable at all? If so, should Unitful import Dates, or use Require?

@ajkeller34
Copy link
Collaborator

I intended to get around to this eventually, but who knows when. A PR would be very helpful. Importing Dates seems reasonable. Thanks!

This was referenced Dec 10, 2019
Merged
Open
@mcabbott mcabbott mentioned this issue May 12, 2020
Closed
@sostock sostock mentioned this issue May 14, 2020
Merged
2 tasks
@sostock
Copy link
Collaborator

sostock commented Nov 8, 2022

This was implemented in #331.

@sostock sostock closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Converting Dates.FixedPeriod to Quantity{...,𝐓} mcabbott/Unitful.jl
4 participants
@rofinn @ajkeller34 @cstjean @sostock