Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] unused dependency on glyphicons #608

Open
1 task done
knz opened this issue Apr 20, 2020 · 2 comments
Open
1 task done

[BUG] unused dependency on glyphicons #608

knz opened this issue Apr 20, 2020 · 2 comments
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Milestone

Comments

@knz
Copy link
Contributor

knz commented Apr 20, 2020

Mandatory Step

  • I am using latest production release of Elegant

Description

Describe the bug
The generated CSS depends on the Glyphicons package which causes:

  • every client to go search for img/glyphicons-halflings.png and img/glyphicons-halflings-white.png which incurs expensive network traffic
  • the CSS to be bloated by 1-2KB (because it embeds bootstrap/sprites.less

All this while none of the generated pages actually use the glyphicons.

To Reproduce
Steps to reproduce the behavior:

  1. build a site
  2. grep for glyphicons in the CSS
  3. look at the HTTP server logs - plenty of unsatisfied requests for the .png file
  4. meanwhile grep for icon- in the generated HTML, observe none is used

Expected behavior

The references to Glyphicons should be removed from the generated CSS because they are unused.

@knz knz added the bug Well, it shouldn’t be doing that. Let’s fix it! label Apr 20, 2020
@talha131 talha131 added this to the 2020 - Q2 milestone Apr 20, 2020
@talha131
Copy link
Member

This happens because Bootstrap needs them. But we do not use that part of the Boostrap. Still this needs to be fixed.

Next release is going to focus on removing Bootstrap completely, which will fix this issue.

@silverhook
Copy link
Member

For reference, this is the issue that deals with removing Boostrap: #429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Development

No branches or pull requests

3 participants