Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CombineModels function RobustBooleanOperation #16

Open
mauigna06 opened this issue Dec 4, 2022 · 3 comments
Open

Add CombineModels function RobustBooleanOperation #16

mauigna06 opened this issue Dec 4, 2022 · 3 comments

Comments

@mauigna06
Copy link
Contributor

RobustBooleanOperation will transform one of the inputs with a small pose variation to get the boolean operation to succeed

The syntax should be:

RobustBooleanOperation(
    inputMesh1,
    inputMesh2,
    resultingMesh,
    mmTranslationDelta=1e-4,
    degRotationDelta=1e-2,
    transformTries=15,
    randomSeed=None
)

Feedback is welcomed
I think I could develop this on the near future so you could assign it to me

Thank you

@mauigna06
Copy link
Contributor Author

@lassoan, I'm willing to implement this logic (and it's GUI) for CombineModels' RobustBooleanOperations because vtkbool sometimes "randomly" fails:

New definition of "process" function would be like code below.

def process(
    inputMesh1,
    inputMesh2,
    resultingMesh,
    booleanOperationType,
    mmTranslationDelta=1e-4,
    degRotationDelta=0.0,
    transformTries=15,
    randomSeed=None
)

Let me know if you'd be willing to merge this change

@lassoan
Copy link
Contributor

lassoan commented Jun 19, 2024

Do you have an example data set to reproduce this issue? Author of vtkbool was quite responsive in fixing issues. Have you reported the issue to him already?

I would much prefer getting the root cause fixed than hide it by some trick, especially because the trick would slow down execution and may cause other issues.

@mauigna06
Copy link
Contributor Author

Hi Andras,

Do you have an example data set to reproduce this issue? Author of vtkbool was quite responsive in fixing issues. Have you reported the issue to him already?

Yes, please here see zippy84/vtkbool#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants