Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit sa.Enum(...).with_variant(postgresql.ENUM(...)) instead of postgresql.ENUM(...) #83

Open
Et7f3 opened this issue Aug 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Et7f3
Copy link

Et7f3 commented Aug 23, 2024

Hello,

Thanks for your works.

I know the project is called alembic-postgresql-enum but from outside it seems to be quite generic and in theory could be applied with multiple backend once create_type is added for others dialect.

Main alembic dev suggest this coding style:
sqlalchemy/alembic#1347 (comment)

One advantage I see is that we don't seems locked with postgresql (in the case in the future I need to change to other db).

@Et7f3 Et7f3 changed the title Can you emit sa.Enum(...).with_variant(postgresql.ENUM(...)) instead of postgresql.ENUM(...) Emit sa.Enum(...).with_variant(postgresql.ENUM(...)) instead of postgresql.ENUM(...) Aug 23, 2024
@AlexandrovRoman AlexandrovRoman added the enhancement New feature or request label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants