Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the use of double with BigDecimal #50

Closed
tdiesler opened this issue Jun 28, 2018 · 2 comments
Closed

Replace the use of double with BigDecimal #50

tdiesler opened this issue Jun 28, 2018 · 2 comments
Assignees
@tdiesler
Labels
task
Milestone
1.0.0

Comments

@tdiesler
Copy link
Collaborator

The use of double leads to all sorts of rounding issues.
The network uses amounts with a fixed scale of 8
@tdiesler tdiesler added the task label Jun 28, 2018
@tdiesler tdiesler added this to the 0.16.1 milestone Jun 28, 2018
@tdiesler tdiesler self-assigned this Jun 28, 2018
@tdiesler tdiesler modified the milestones: 0.16.1, 0.17.0 Jun 28, 2018
tdiesler added a commit that referenced this issue Jun 28, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
ef93136
tdiesler added a commit to jboss-fuse/bitcoin-rpc-client that referenced this issue Jun 28, 2018
@tdiesler
[resolves Polve#50] Replace the use of double with BigDecimal
841a28c
@tdiesler
Copy link
Collaborator Author

Done

This is an incompatible change and must wait for the next major

@tdiesler tdiesler mentioned this issue Jun 28, 2018
Closed
tdiesler added a commit to jboss-fuse/bitcoin-rpc-client that referenced this issue Jun 28, 2018
@tdiesler
[resolves Polve#50] Replace the use of double with BigDecimal
1018761
tdiesler added a commit that referenced this issue Jun 28, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
cf73acd
@Polve
Copy link
Owner

Polve commented Jun 29, 2018

That was sorely needed, thanks tdiesler for your work here.

tdiesler added a commit that referenced this issue Jul 5, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
147ac43
tdiesler added a commit that referenced this issue Jul 6, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
e42f503
tdiesler added a commit that referenced this issue Jul 18, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
e91d96b
tdiesler added a commit that referenced this issue Jul 18, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
6631dd0
tdiesler added a commit that referenced this issue Jul 18, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
ad03aac
tdiesler added a commit that referenced this issue Jul 24, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
97723d7
tdiesler added a commit that referenced this issue Jul 25, 2018
@tdiesler
[resolves #50] Replace the use of double with BigDecimal
5779665
tdiesler added a commit to jboss-fuse/bitcoin-rpc-client that referenced this issue Jul 25, 2018
@tdiesler
[resolves Polve#50] Replace the use of double with BigDecimal
d471227
This was referenced Nov 8, 2018
Closed
Closed
tdiesler added a commit to jboss-fuse/bitcoin-rpc-client that referenced this issue Nov 8, 2018
@tdiesler
[resolves Polve#50] Replace the use of double with BigDecimal
c7feea2
tdiesler added a commit to jboss-fuse/bitcoin-rpc-client that referenced this issue Nov 8, 2018
@tdiesler
[resolves Polve#50] Replace the use of double with BigDecimal
4e3006a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdiesler tdiesler

Labels
task
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@tdiesler @Polve