Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking existing PNID - Server doesn't check email validity #28

Open
InternalLoss opened this issue Feb 2, 2022 · 5 comments
Open

Linking existing PNID - Server doesn't check email validity #28

InternalLoss opened this issue Feb 2, 2022 · 5 comments

Comments

@InternalLoss
Copy link

When trying to link a PNID to a console, the server should check PNID, password, AND email - the following HTTP headers are sent:

X-Nintendo-EMAIL: email@email.com
X-Nintendo-Local-Pin-Flag: N

NB: X-Nintendo-Local-Pin-Flag: Y is set if Parental Controls IS enabled.

@InternalLoss
Copy link
Author

Bumping this for security reasons.

@jonbarrow
Copy link
Member

Bumping this for security reasons.

I believe we already discussed this but isn't this only a "security" issue if the attacker already has the users username/password? If an attacker already has a users login it's game over, they can already get the users email address just by logging in?

@InternalLoss
Copy link
Author

Potentially, though it may let them bypass usual checks (like CAPTCHA/etc) to retrieve email, assuming we had a CAPTCHA on logins on the website in future.

@jonbarrow
Copy link
Member

What is the error sent when the email does not match

@luni-moon
Copy link

Has this been resolved, or may I work on seeing if I can fix it if I find the error in source code, not matching it correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants