dev: Upgrade to eslint 9

I didn't want to spend too much time on this, so I've just reconfigured eslint with the recommended configuration, which should be good enough.
Probesys · May 7, 2024 · 4caf4ab · 4caf4ab
1 parent af602f5
commit 4caf4ab
Show file tree

Hide file tree

Showing 11 changed files with 142 additions and 1,878 deletions.
diff --git a/.eslint.config.js b/.eslint.config.js
@@ -0,0 +1,11 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+export default [
+  {
+      languageOptions: {
+          globals: globals.browser,
+      }
+  },
+  pluginJs.configs.recommended,
+];
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/assets/javascripts/application.js b/assets/javascripts/application.js
@@ -2,7 +2,7 @@
 // Copyright 2022-2024 Probesys
 // SPDX-License-Identifier: AGPL-3.0-or-later
 
-import * as Turbo from '@hotwired/turbo'; // eslint-disable-line no-unused-vars
+import * as Turbo from '@hotwired/turbo';
 import { Application } from '@hotwired/stimulus';
 
 import ButtonSelectController from '@/controllers/button_select_controller.js';
@@ -67,7 +67,7 @@ document.addEventListener('turbo:submit-start', (event) => {
     }
 });
 
-document.addEventListener('turbo:before-render', (event) => {
+document.addEventListener('turbo:before-render', () => {
     if (disableScroll && Turbo.navigator.currentVisit) {
         // As explained on GitHub, `Turbo.navigator.currentVisit.scrolled`
         // is internal and private attribute: we should NOT access it.

diff --git a/assets/javascripts/controllers/checkboxes_controller.js b/assets/javascripts/controllers/checkboxes_controller.js
@@ -13,7 +13,7 @@ export default class extends Controller {
         this.refreshControls();
     }
 
-    checkAll (event) {
+    checkAll () {
         const checkboxes = this.element.querySelectorAll('input[type="checkbox"]:not([disabled])');
 
         checkboxes.forEach((checkbox) => {
@@ -23,7 +23,7 @@ export default class extends Controller {
         this.refreshControls();
     }
 
-    uncheckAll (event) {
+    uncheckAll () {
         const checkboxes = this.element.querySelectorAll('input[type="checkbox"]:not([disabled])');
 
         checkboxes.forEach((checkbox) => {

diff --git a/assets/javascripts/controllers/form_priority_controller.js b/assets/javascripts/controllers/form_priority_controller.js
@@ -27,7 +27,7 @@ export default class extends Controller {
         return ['urgency', 'impact', 'priority'];
     }
 
-    updatePriority (event) {
+    updatePriority () {
         const urgency = this.urgencyTarget.value;
         const impact = this.impactTarget.value;
 

diff --git a/assets/javascripts/controllers/form_ticket_actors_controller.js b/assets/javascripts/controllers/form_ticket_actors_controller.js
@@ -13,7 +13,7 @@ export default class extends Controller {
         this.refreshAssignees();
     }
 
-    refreshAssignees (event) {
+    refreshAssignees () {
         if (!this.hasTeamsTarget) {
             return;
         }

diff --git a/assets/javascripts/controllers/password_controller.js b/assets/javascripts/controllers/password_controller.js
@@ -21,7 +21,7 @@ export default class extends Controller {
         }
     }
 
-    toggle (e) {
+    toggle () {
         if (this.inputTarget.type === 'password') {
             this.inputTarget.type = 'text';
         } else {

diff --git a/assets/javascripts/controllers/popup_controller.js b/assets/javascripts/controllers/popup_controller.js
@@ -30,7 +30,7 @@ export default class extends Controller {
     /**
      * Update the aria-expanded attribute on toggle.
      */
-    update (event) {
+    update () {
         const openerElement = this.element.querySelector('.popup__opener');
         if (openerElement) {
             openerElement.setAttribute('aria-expanded', this.element.open);
@@ -40,7 +40,7 @@ export default class extends Controller {
     /**
      * Close the menu.
      */
-    close (event) {
+    close () {
         if (!this.element.open) {
             return;
         }

diff --git a/assets/javascripts/controllers/tinymce_controller.js b/assets/javascripts/controllers/tinymce_controller.js
@@ -78,18 +78,16 @@ export default class extends Controller {
 
             xhr.onload = () => {
                 if (xhr.status === 401) {
-                    // eslint-disable-next-line prefer-promise-reject-errors
                     reject({ message: 'You are not authorized to upload files.', remove: true });
                     return;
                 }
 
                 let json;
                 try {
                     json = JSON.parse(xhr.responseText);
-                } catch (e) {
+                } catch {
                     console.error('Bad JSON from server: ' + xhr.responseText);
 
-                    // eslint-disable-next-line prefer-promise-reject-errors
                     reject({ message: 'Bad response from the server.', remove: true });
                     return;
                 }
@@ -101,7 +99,6 @@ export default class extends Controller {
                 ) {
                     console.error('Bad JSON from server: ' + xhr.responseText);
 
-                    // eslint-disable-next-line prefer-promise-reject-errors
                     reject({ message: 'Bad response from the server.', remove: true });
                     return;
                 }
@@ -111,7 +108,6 @@ export default class extends Controller {
                         console.error('Unexpected error from server: ' + json.description);
                     }
 
-                    // eslint-disable-next-line prefer-promise-reject-errors
                     reject({ message: json.error, remove: true });
                     return;
                 }
@@ -125,7 +121,6 @@ export default class extends Controller {
             xhr.onerror = () => {
                 console.error('Unexpected error from server: error code ' + xhr.status);
 
-                // eslint-disable-next-line prefer-promise-reject-errors
                 reject({ message: 'Bad response from the server.', remove: true });
             };