Skip to content

Commit

Permalink
dev: Clean all the Docker stuff on make docker-clean
Browse files Browse the repository at this point in the history
There were two problems with the command `make docker-clean`:

- the small one: volumes were not deleted, so when we upgraded from
  PGSQL 11 to 12, the data in the container was incompatible;
- the big one: containers related to profiles (i.e. databases and LDAP)
  weren't included in the command at all.

The second issue broke the system because `make docker-clean` deleted
the network, but not the pgsql container. So when we restarted the
services, pgsql was looking for the old network and failed.
  • Loading branch information
marien-probesys committed Jan 31, 2024
1 parent 959ed9d commit aea07f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ docker-build: ## Rebuild Docker containers

.PHONY: docker-clean
docker-clean: ## Clean the Docker stuff
$(DOCKER_COMPOSE) down
$(DOCKER_COMPOSE) --profile pgsql --profile mariadb --profile ldap down -v

.PHONY: docker-image
docker-image: ## Build the Docker image for production (take a VERSION argument)
Expand Down

0 comments on commit aea07f5

Please sign in to comment.