Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPX output format #1489

Closed
TheMarex opened this issue May 24, 2015 · 3 comments
Closed

Remove GPX output format #1489

TheMarex opened this issue May 24, 2015 · 3 comments
Milestone

Comments

@TheMarex
Copy link
Member

Responses by the server should handled in JSON only.

  • The response of most plugins has no meaningful mapping to GPX
  • The current implementation of GPX is a hack that involves rendering JSON first and then transforming that into XML
  • It creates an unneeded complexity in the response rendering code
  • It is off little use in the current form GPX File Export #1180

Since this breaks the API we should aim for 5.0

@TheMarex TheMarex added this to the 0.5 milestone May 24, 2015
@stevage
Copy link

stevage commented Jun 3, 2015

What does this mean for the current way GPX's are generated in OSRM-web? Is the "hack" that you refer to done in the client already, and hence this isn't needed?

@TheMarex
Copy link
Member Author

TheMarex commented Jun 9, 2015

@stevage no gpx is currently generated at the server. But it is pretty trivial for the client to transform JSON to XML if needed.

@TheMarex
Copy link
Member Author

TheMarex commented Jan 8, 2016

This was implemented as part of #1851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants