Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create proper confirm dialog and replace all confirm() calls #262

Closed
3 tasks
Sekkmer opened this issue Jun 2, 2023 · 0 comments · Fixed by #421
Closed
3 tasks

Create proper confirm dialog and replace all confirm() calls #262

Sekkmer opened this issue Jun 2, 2023 · 0 comments · Fixed by #421
Labels
Complexity: 2 - Medium Tasks that are either larger or require deeper knowledge of specific technology Component: Client Changes to client side of things Good first issue Good for newcomers Type: Improvement Improvement of existing feature

Comments

@Sekkmer
Copy link
Member

Sekkmer commented Jun 2, 2023 •
edited by Jomshir98
Loading

The following things should be done as part of this issue:

  • Create a modal confirmation dialog that can be used using await
  • Migrate all uses of current confirm calls to this dialog
  • Add a lint rule that forbids usage of alert and confirm
@Sekkmer Sekkmer added Component: Client Changes to client side of things Type: Fix Fixes something that isn't working labels Jun 2, 2023
@Sekkmer Sekkmer mentioned this issue Jun 2, 2023
Merged
@Jomshir98 Jomshir98 added Type: Improvement Improvement of existing feature Type: Fix Fixes something that isn't working and removed Type: Fix Fixes something that isn't working labels Jun 2, 2023
@Sekkmer Sekkmer changed the title [FIX] Create proper confirm dialog and replace all confirm() calls Create proper confirm dialog and replace all confirm() calls Jun 5, 2023
@Jomshir98 Jomshir98 added Complexity: 2 - Medium Tasks that are either larger or require deeper knowledge of specific technology Good first issue Good for newcomers labels Aug 30, 2023
@Sekkmer Sekkmer mentioned this issue Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: 2 - Medium Tasks that are either larger or require deeper knowledge of specific technology Component: Client Changes to client side of things Good first issue Good for newcomers Type: Improvement Improvement of existing feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Friends UI Navigation Project-Pandora-Game/pandora
2 participants
@Sekkmer @Jomshir98