Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] Rework how UI inputs work, standardize input logic #830

Merged
merged 10 commits into from
Sep 1, 2024

Conversation

Jomshir98
Copy link
Member

@Jomshir98 Jomshir98 commented Sep 1, 2024

References

fixes #672
fixes #810

About The Pull Request

Reworks how all inputs are done using standardized, custom input components. These avoid updating the current value if user is focused on the input or inputted into it recently.
Also adds a lint rule to warn that you should use those.

Changelog

Platform changes:
- Reworked all input fields throughout Pandora to work much better:
  - Inputs can now be written freely - they do not need to have a valid value at all times. This means that you can now select full value of a numeric input and just delete it and rewrite it.
  - Inputs no longer "fight" you while you are focused on them and for a second after any change you make.
  - When you un-focus an input, it will update with the actual value after a second (if the value differs from what you entered - either because your input was invalid, or because someone else in the same space changed it meanwhile)
  
Fixes:
- Fixed that posing your character rapidly might not apply the very last change you did
- Fixed weird spacing inside color input button

Checklist

  • The change has been tested locally
  • Added documentation to the new code and updated existing documentation where needed
  • I understand this patch is submitted under the Pandora's Contributor Agreement

@Jomshir98 Jomshir98 added Type: Improvement Improvement of existing feature Component: Client Changes to client side of things Type: Fix Fixes something that isn't working labels Sep 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is from a Lead Developer.

@Jomshir98 Jomshir98 merged commit 521b494 into master Sep 1, 2024
7 checks passed
@Jomshir98 Jomshir98 deleted the feature/ui-standardisation branch September 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Client Changes to client side of things Type: Fix Fixes something that isn't working Type: Improvement Improvement of existing feature
Development

Successfully merging this pull request may close these issues.

Client:UI: Rework input elements Fix input fields in the posing tab to allow better usability
1 participant