Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the links from our navigation bar be relative? #263

Open
clyne opened this issue Jun 27, 2022 · 6 comments
Open

Should the links from our navigation bar be relative? #263

clyne opened this issue Jun 27, 2022 · 6 comments
Labels
infrastructure Infrastructure related issue

Comments

@clyne
Copy link
Contributor

clyne commented Jun 27, 2022

Many (all) of the links from our top level navigation bar menu items, such as the one under Community below, are full URLs (not relative links). Hence previewing locally as described in our contributors guide here is not possible: the link takes you to the production site.

{'name': 'Home', 'url': 'https://projectpythia.org'},

@clyne clyne added the infrastructure Infrastructure related issue label Jun 27, 2022
@kmpaul
Copy link
Collaborator

kmpaul commented Jun 27, 2022

That's by design. There are other links further down in the page that are relative that will take you to the locally hosted site.

@clyne
Copy link
Contributor Author

clyne commented Jun 27, 2022

That indeed works. Thanks. However, I'm not sure what to do about the confusion our contributor's guide will cause. Any thoughts @kmpaul ?

@kmpaul
Copy link
Collaborator

kmpaul commented Jun 27, 2022

I think we should just include a warning that (1) any external links from the locally built site (or in the preview) will take you away from the preview and (2) any internal links in the top menubar will take you away from the preview, too.

@kmpaul
Copy link
Collaborator

kmpaul commented Jun 27, 2022

It might be possible to make the internal links in the top-bar relative. I'll have to look into that.

@clyne
Copy link
Contributor Author

clyne commented Jun 27, 2022

Thanks. I don't think it is high priority because it is mostly the Pythia team that touches the landing pages.

@jukent
Copy link
Contributor

jukent commented Oct 5, 2022

Having them be absolute links helps with consistency across the sites, I think. The low hanging fruit would be to add the warning to the contributor's guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
Status: Backlog
Development

No branches or pull requests

4 participants