Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [神器0001] 見通しの書でバニラモブの耐性が正しく表示されないバグを修正 #1399

Merged
merged 7 commits into from
Jun 27, 2023
Merged

🐛 [神器0001] 見通しの書でバニラモブの耐性が正しく表示されないバグを修正 #1399

merged 7 commits into from
Jun 27, 2023

Conversation

haiiro2gou
Copy link
Member

@haiiro2gou haiiro2gou commented May 25, 2023 •
edited
Loading

分割先: #1403

@haiiro2gou haiiro2gou requested a review from ChenCMD as a code owner May 25, 2023 15:33
@haiiro2gou haiiro2gou changed the title 🐛 見通しの書でバニラモブの耐性が正しく表示されないバグを修正 🐛 [神器0001] 見通しの書でバニラモブの耐性が正しく表示されないバグを修正 May 25, 2023
ChenCMD
ChenCMD requested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@ChenCMD ChenCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

瑠璃が失礼しました(?)
んでまずは対応ありがとう。
ただ、このバグの場合、本質的には api:modifier/**/get が取得前に api: Return.** を reset しないことに問題があるので、そっちを修正してほしいかも

@haiiro2gou haiiro2gou requested a review from ChenCMD June 26, 2023 17:10
@haiiro2gou
Copy link
Member Author

もしかすると２つに分けたほうがいいかもしれない

@ChenCMD
Copy link
Member

ChenCMD commented Jun 26, 2023

やる気があるならそうしてくれると助かるかも、ただどちらでもいいくらい

後ちょっと私情で時間ないから雑にレビューしちゃうんだけど神器側のremoveは使う前より使った後のほうがきれいかも

@haiiro2gou
Copy link
Member Author

あとでPRは分けておきます

@haiiro2gou haiiro2gou mentioned this pull request Jun 27, 2023
Merged
ChenCMD
ChenCMD approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@ChenCMD ChenCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ChenCMD ChenCMD merged commit da9b71a into ProjectTSB:master Jun 27, 2023
1 check passed
@haiiro2gou haiiro2gou deleted the fix/haiiro_0001 branch June 27, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenCMD ChenCMD ChenCMD approved these changes

@Lapis-LJA Lapis-LJA Lapis-LJA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haiiro2gou @ChenCMD @Lapis-LJA