Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【モブ0321】ミニガーディアンを作成 #1415

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Chuzume
Copy link
Contributor

@Chuzume Chuzume commented Jul 22, 2023

ランク3モブ。水中に出すことを想定していますが、外に飛び出してもそのまま浮遊します。
image

@Chuzume Chuzume requested a review from ChenCMD as a code owner July 22, 2023 20:36
scoreboard players remove @s[scores={8X.HurtTime=0..}] 8X.HurtTime 1

# 攻撃中じゃなければ移動
execute unless score @s[tag=!8X.Mode.Attack] 8X.HurtTime matches 0..40 unless score @s 8X.Tick matches 40.. facing entity @p feet positioned ^ ^ ^-50 rotated as @s positioned ^ ^ ^-3000 facing entity @s eyes positioned as @s run tp @s ^ ^ ^0.1 ~ ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは攻撃中じゃない かつ 8X.HurtTimeがセットされていたらという条件で間違いなさそう?

execute unless score @s[tag=!8X.Mode.Attack] 8X.HurtTime matches 0..40 unless score @s 8X.Tick matches 40.. facing entity @p feet positioned ^ ^ ^-50 rotated as @s positioned ^ ^ ^-3000 facing entity @s eyes positioned as @s run tp @s ^ ^ ^0.1 ~ ~

# 付近にプレイヤーがいたら攻撃待機
execute if entity @a[distance=..8] run tag @s add 8X.Mode.Attack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag=PlayerShouldInvulnerableを入れたほうがいいかも?

# @within function asset:mob/0321.mini_guardian/tick/2.tick

# 攻撃モードに移行
tag @s add 8X.Mode.Attack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これって必要……なのかしら?

Copy link
Contributor

@EllaCoat EllaCoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かなところを直せば、おおよそ問題はなさそう
あとは、おそらくブランチが古いことくらい

# 第二属性
data modify storage lib: Argument.ElementType set value "Water"
# ダメージ
function lib:damage/modifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実行者をミニガーディアン自身にしてあげないと死亡ログがバグる


#> インターバルのスコアホルダー
# @private
#declare score_holder $DamageInterval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リセットしてなさそう


#> インターバルのスコアホルダー
# @private
#declare score_holder $SoundInterval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リセットしてなさそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants