-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
任意のオブジェクトを追加できるAssetと、それのテンプレート生成用にSetting.jsonを作った #1530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8fdde7.
ChenCMD
requested changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
概ね良さそう、ただ MUST があるので Request Changes~
TheSkyBlessing/data/asset_manager/functions/object/triggers/tick.mcfunction
Outdated
Show resolved
Hide resolved
TheSkyBlessing/data/asset_manager/functions/common/context_id/stash.mcfunction
Outdated
Show resolved
Hide resolved
…stash.mcfunction Co-authored-by: Chen <scnmed.g@gmail.com>
…ck.mcfunction Co-authored-by: Chen <scnmed.g@gmail.com>
ChenCMD
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
・ユーザー向けの細かい説明は後々書きますが、大体はサンプルに記述してあります。
・今後抽象的な飛び道具の雛形などを作り、それを継承する形で色々なものを実装できると思います