Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmit call fails when size is > 12 #443

Closed
srobins6 opened this issue Nov 29, 2018 · 10 comments
Closed

Transmit call fails when size is > 12 #443

srobins6 opened this issue Nov 29, 2018 · 10 comments

Comments

@srobins6
Copy link

srobins6 commented Nov 29, 2018

In LibCecSharp the Transit function fails when command.Parameters.Size > 12

@malard
Copy link
Member

malard commented Nov 29, 2018

maximum length for cec spec is this, we can put a guard to help developers

@srobins6
Copy link
Author

Where are you getting the maximum number? All the documentation I can find says it's 16, not 12.

@malard
Copy link
Member

malard commented Nov 29, 2018

the first 4 are taken by transmission data, @opdenkamp will confirm my thoughts

@srobins6
Copy link
Author

thank you!

@srobins6
Copy link
Author

Can you elaborate on what specific information those 4 bytes represent?

@opdenkamp
Copy link
Contributor

Hi @srobins6 , I've responded to your question in the email to you've sent. You can send 16 bytes of data, 2 of which are taken by the header (initiator, destination, opcode). I've verified that this is working correctly on libCEC 4.0.2+

There was a bug in an old version of libCEC which prevented the last bytes from being sent, which has been fixed. If it's not working for you, then you may have to upgrade: https://github.com/Pulse-Eight/libcec/releases/tag/libcec-4.0.3

@srobins6
Copy link
Author

srobins6 commented Dec 2, 2018

I am still having this issue with libcecsharp specifically, haven't tested with other libraries

@opdenkamp
Copy link
Contributor

I have tested sending a 16 byte packet with CecSharpTester: https://github.com/Pulse-Eight/cec-dotnet/tree/180cbe2b4e2b2d6a58c4b22d09760aba4b67a8e5/src/CecSharpTester
It was received correctly by another CEC adapter on which I was running cec-client.

Have you upgraded to the latest version?

@opdenkamp opdenkamp reopened this Dec 2, 2018
@opdenkamp
Copy link
Contributor

Updating the status here too: this is caused by a bug in the firmware on the TX side, which results in TRANSMIT_FAILED_TIMEOUT_DATA when attempting to send out a 16 byte packet.

@opdenkamp
Copy link
Contributor

This isn't caused by the firmware after all, but was caused by a buffer that couldn't fit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants