[stm32l1] [i2c] Hanging on I2C error

[Cr0s]

Hello everyone,

It's possible to overhaul current STM32L1's I2C peripheral driver code to remove the

while(1){}

from the I2C error ISR?

Due to this stub, the application code freezes if any I2C bus error occurs. That obviously makes an application less robust.

The current implementation code is like this:

void I2C_0_ERR_ISR(void)
{
    unsigned state = I2C1->SR1;
    DEBUG("\n\n### I2C1 ERROR OCCURED ###\n");
    DEBUG("status: %08x\n", state);
    if (state & I2C_SR1_OVR) {
        DEBUG("OVR\n");
    }
    if (state & I2C_SR1_AF) {
        DEBUG("AF\n");
    }
    if (state & I2C_SR1_ARLO) {
        DEBUG("ARLO\n");
    }
    if (state & I2C_SR1_BERR) {
        DEBUG("BERR\n");
    }
    if (state & I2C_SR1_PECERR) {
        DEBUG("PECERR\n");
    }
    if (state & I2C_SR1_TIMEOUT) {
        DEBUG("TIMEOUT\n");
    }
    if (state & I2C_SR1_SMBALERT) {
        DEBUG("SMBALERT\n");
    }
    while (1) {}
}

My suggestion is to replace this hanging stub to the routine which rising an error flag somewhere instead. It will make possible to handle bus errors on application side and gives more control over the situation.

Best regards,
Cr0s

[LudwigKnuepfer]

See #3366