Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for unsafe for users #14

Closed
RandomInsano opened this issue Sep 2, 2018 · 1 comment
Closed

Remove the need for unsafe for users #14

RandomInsano opened this issue Sep 2, 2018 · 1 comment

Comments

@RandomInsano
Copy link
Owner

RandomInsano commented Sep 2, 2018

Currently, the forced coercion from a read into the Guitar Hero or Mad Maestro controllers require you to access raw parts of the ControllerData union. While this is safe from crashing the app, users shouldn't need to know how to do this or do their own error checking.

So! We should do that for them. Ideally with a safety check that the controller identifier matches the device they're trying to coerce.

After this is done, gh and b fields of the union should be made private again.

@RandomInsano
Copy link
Owner Author

Heh. This is a duplicate of #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant