Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add approximate_user_install_count to AppInfo #9915

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add approximate_user_install_count to AppInfo #9915

merged 2 commits into from
Aug 28, 2024

Conversation

AbstractUmbra
Copy link
Contributor

@AbstractUmbra AbstractUmbra commented Aug 11, 2024 •
edited
Loading

Summary

See title.

Related discord-api-docs PR

Nothing in the above docs says this will be available in PartialAppInfo so I added it to the full object instead.

DiscordPTB_6yy2qq8szQ

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@AbstractUmbra AbstractUmbra marked this pull request as ready for review August 11, 2024 11:18
Kile
Kile approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Kile Kile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, when will this be merged?

@Rapptz Rapptz merged commit d578709 into Rapptz:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kile Kile Kile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbstractUmbra @Kile @Rapptz