Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shareReplay is not listed in the docs #3184

Closed
IgorMinar opened this issue Dec 13, 2017 · 6 comments
Closed

shareReplay is not listed in the docs #3184

IgorMinar opened this issue Dec 13, 2017 · 6 comments
Labels
docs Issues and PRs related to documentation

Comments

@IgorMinar
Copy link
Contributor

RxJS version:
5.5.4

Code to reproduce:
http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html#instance-method-share

Expected behavior:
shareReplay should be listed right under share

Actual behavior:
docs missing

@benlesh
Copy link
Member

benlesh commented Dec 13, 2017

cc @ladyleet

@ladyleet
Copy link
Member

thx @IgorMinar for pointing this out!

@Airblader
Copy link
Contributor

Airblader commented Dec 20, 2017

So this issue should be closed since @ladyleet opened one over at rxjs-docs, right?

Edit: Never mind, I mistook rxjs-docs for the current place of the docs, but it seems to be the next gen of docs instead.

@kwonoj kwonoj added the docs Issues and PRs related to documentation label Feb 21, 2018
@niklas-wortmann
Copy link
Member

So shareReplay is now listed in the new docs, but the documentation is really poor and should be improved with an example and a description what this operator is actually doing

@cartant
Copy link
Collaborator

cartant commented Aug 27, 2018

@jwo719 Regarding documentation examples, it might be worthwhile waiting until #3336 is fixed as there are a couple of use cases and the fix for the linked issue will involve the introduction of a flag. I'm looking into a fix at the moment.

@cartant
Copy link
Collaborator

cartant commented Jan 28, 2019

Closing this as it's now listed.

@cartant cartant closed this as completed Jan 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issues and PRs related to documentation
Projects
None yet
Development

No branches or pull requests

7 participants