New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] include global footer in npm package #429

Closed

bennypowers opened this issue Jul 13, 2022 · 1 comment · Fixed by #438

Assignees

Labels

bug

Member

bennypowers commented Jul 13, 2022

We neglected to include rh-global-footer.js in the latest release.

Originally posted by @bennypowers in #420 (reply in thread)

Member Author

bennypowers commented Jul 13, 2022

Turns out this is more difficult than originally anticipated, since esbuild doesn't yet support multiple entry points while preserving module structure but also bundling css into javascript modules like we do.

We can investigate switching to rollup for slower but more correct dist bundles, while we wait for esbuild to develop the necessary options and apis.

bennypowers self-assigned this

bennypowers mentioned this issue

chore: build with typescript #438

Merged

bennypowers added the bug label

bennypowers closed this as completed in #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment