From 1240d37f8d7d095b82ddc7be1f8927856980b2bd Mon Sep 17 00:00:00 2001 From: Brandon Squizzato Date: Tue, 15 Jun 2021 17:06:36 -0400 Subject: [PATCH] Handle empty response in 'check_ready' --- bonfire/openshift.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bonfire/openshift.py b/bonfire/openshift.py index 9d96e728..893bc9d5 100644 --- a/bonfire/openshift.py +++ b/bonfire/openshift.py @@ -404,9 +404,11 @@ def _observe(self, item): def check_ready(self): response = get_json(self.restype, name=self.name, namespace=self.namespace) - self._uid = response["metadata"]["uid"] - self._observe(response) - return all([r["ready"] is True for _, r in self.observed_resources.items()]) + if response: + self._uid = response["metadata"]["uid"] + self._observe(response) + return all([r["ready"] is True for _, r in self.observed_resources.items()]) + return False def _check_with_periodic_log(self): if self.check_ready():