From 19d3461cdfb6e9008d1999bef22b924ef1fc0060 Mon Sep 17 00:00:00 2001 From: CD Cabrera Date: Tue, 24 Aug 2021 15:54:33 -0400 Subject: [PATCH] fix(productView): ent-4247 disable take a tour header button (#774) --- src/components/pageLayout/pageHeader.js | 4 ++++ .../__tests__/__snapshots__/productView.test.js.snap | 8 ++++---- .../__snapshots__/productViewMissing.test.js.snap | 4 ++-- .../productViewOpenShiftContainer.test.js.snap | 2 +- src/components/productView/productView.js | 2 +- src/components/productView/productViewMissing.js | 4 +--- .../productView/productViewOpenShiftContainer.js | 2 +- 7 files changed, 14 insertions(+), 12 deletions(-) diff --git a/src/components/pageLayout/pageHeader.js b/src/components/pageLayout/pageHeader.js index dcf56ce5f..ce57a1663 100644 --- a/src/components/pageLayout/pageHeader.js +++ b/src/components/pageLayout/pageHeader.js @@ -6,6 +6,10 @@ import { ExternalLinkAltIcon } from '@patternfly/react-icons'; import { helpers } from '../../common'; import { translate } from '../i18n/i18n'; +/** + * ToDo: Review removing the "includeTour" prop and associated button code. + * ...instead of disabling it, ENT-4247 + */ /** * Render a platform page header. * diff --git a/src/components/productView/__tests__/__snapshots__/productView.test.js.snap b/src/components/productView/__tests__/__snapshots__/productView.test.js.snap index 4b13d9a5c..975cef8a9 100644 --- a/src/components/productView/__tests__/__snapshots__/productView.test.js.snap +++ b/src/components/productView/__tests__/__snapshots__/productView.test.js.snap @@ -5,7 +5,7 @@ exports[`ProductView Component should allow custom product views: custom graphCa className="" > @@ -138,7 +138,7 @@ exports[`ProductView Component should allow custom product views: custom toolbar className="" > @@ -215,7 +215,7 @@ exports[`ProductView Component should allow custom product views: custom toolbar className="" > @@ -292,7 +292,7 @@ exports[`ProductView Component should render a non-connected component: non-conn className="" > diff --git a/src/components/productView/__tests__/__snapshots__/productViewMissing.test.js.snap b/src/components/productView/__tests__/__snapshots__/productViewMissing.test.js.snap index 515ed00ef..47b7a591b 100644 --- a/src/components/productView/__tests__/__snapshots__/productViewMissing.test.js.snap +++ b/src/components/productView/__tests__/__snapshots__/productViewMissing.test.js.snap @@ -21,7 +21,7 @@ exports[`ProductViewMissing Component should render a non-connected component: n className="curiosity-missing-view" > @@ -151,7 +151,7 @@ exports[`ProductViewMissing Component should render a predictable set of product className="curiosity-missing-view" > diff --git a/src/components/productView/__tests__/__snapshots__/productViewOpenShiftContainer.test.js.snap b/src/components/productView/__tests__/__snapshots__/productViewOpenShiftContainer.test.js.snap index dff0ca7f8..6c58bd457 100644 --- a/src/components/productView/__tests__/__snapshots__/productViewOpenShiftContainer.test.js.snap +++ b/src/components/productView/__tests__/__snapshots__/productViewOpenShiftContainer.test.js.snap @@ -5,7 +5,7 @@ exports[`ProductViewOpenShiftContainer Component should render a non-connected c className="" > diff --git a/src/components/productView/productView.js b/src/components/productView/productView.js index d4b898653..7b7fd1fe4 100644 --- a/src/components/productView/productView.js +++ b/src/components/productView/productView.js @@ -109,7 +109,7 @@ const ProductView = ({ routeDetail, t, toolbarGraph, toolbarGraphDescription, to return ( - + {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME, context: productLabel })} diff --git a/src/components/productView/productViewMissing.js b/src/components/productView/productViewMissing.js index 986628a54..268a8c5d8 100644 --- a/src/components/productView/productViewMissing.js +++ b/src/components/productView/productViewMissing.js @@ -49,9 +49,7 @@ const ProductViewMissing = ({ availableProductsRedirect, t }) => { return ( - - {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME })} - + {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME })} {availableProducts.map(product => ( diff --git a/src/components/productView/productViewOpenShiftContainer.js b/src/components/productView/productViewOpenShiftContainer.js index 37ff637a3..678ca57dd 100644 --- a/src/components/productView/productViewOpenShiftContainer.js +++ b/src/components/productView/productViewOpenShiftContainer.js @@ -162,7 +162,7 @@ const ProductViewOpenShiftContainer = ({ routeDetail, t }) => { return ( - + {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME, context: viewProductLabel })} {productConfig.map(config => renderProduct(config, uomValue))}