Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEAR Contracts: Fix the integration tests #20

Open
MantisClone opened this issue Sep 15, 2023 · 3 comments
Open

NEAR Contracts: Fix the integration tests #20

MantisClone opened this issue Sep 15, 2023 · 3 comments

Comments

@MantisClone
Copy link
Member

MantisClone commented Sep 15, 2023

Problem

The integration tests fail on the main branch

status: Failure(Action #4: PrepareError: Error happened while deserializing the module.),
@MantisClone MantisClone self-assigned this Sep 15, 2023
@MantisClone
Copy link
Member Author

MantisClone commented Sep 15, 2023

This error seems to indicate that we're using opcodes outside the wasm-core-1 specification

Source: near/nearcore#8358 (comment)

@MantisClone
Copy link
Member Author

near/nearcore#8358 (comment)

I searched for ways to disable the sign-ext opcodes on the compiler and ran across this issue that seems to indicate that the option to disable sign-ext exists 👍 but that it's not working. 😢 rust-lang/rust#109807

Thus, I will likely pursue the wasm-opt --signext-lowering approach.

@MantisClone
Copy link
Member Author

This issue was "bandaid" fixed by #16 which downgrades to Rust 1.67 - thus avoiding the later versions where sign-ext opcodes are added by default.

This issue should remain open until we've found a long-term fix.

@MantisClone MantisClone removed their assignment Sep 21, 2023
@MantisClone MantisClone changed the title Fix the integration tests NEAR Contracts: Fix the integration tests Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🐞🧹 Backlog: Bug, Tech Debt, or Chore
Development

No branches or pull requests

1 participant