Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ruby dependency #13231

Closed
jwnimmer-tri opened this issue May 4, 2020 · 3 comments · Fixed by #13262
Closed

Remove ruby dependency #13231

jwnimmer-tri opened this issue May 4, 2020 · 3 comments · Fixed by #13262
Assignees
@jwnimmer-tri
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware

Comments

@jwnimmer-tri
Copy link
Collaborator

Asking users to install a full ruby interpreter just to build Drake from source seems overly heavyweight.

We only use it for https://github.com/osrf/sdformat/blob/master/sdf/embedSdf.rb, so it should be possible to rewrite that script in a lighter language (either within Drake, or upstream).

See #8976 for where we added ruby.
@jwnimmer-tri jwnimmer-tri added priority: low unused team: kitware component: build system Bazel, CMake, dependencies, memory checkers, linters labels May 4, 2020
@jwnimmer-tri jwnimmer-tri self-assigned this May 5, 2020
@jwnimmer-tri
Copy link
Collaborator Author

My current plan of attack:

  • PR to sdformat refactoring the "embed" codegen logic
    • remove application-layer versioning logic from codegen
      • be a boring dictionary of relative_filename => contents
        • the codegen rb script will be like 10 lines long
    • stop relying on the global initialization and destruction fiasco
  • Upgrade sdformat in Drake
  • Re-implement the (now boring) codegen script in python

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented May 5, 2020 •
edited
Loading

FTR See old BitBucket PR discussion:
https://github.com/osrf/sdformat/blame/9eb6b99c2c8295fcf533589b4e8e6f4fd5fa623a/Changelog.md#L527
https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/434/page/1#comment-65236228

EDIT: My patch got lost, but meh, it was easy anywho.

@jwnimmer-tri jwnimmer-tri mentioned this issue May 7, 2020
Merged
@jwnimmer-tri
Copy link
Collaborator Author

We'll see where gazebosim/sdformat#270 takes us.

@jwnimmer-tri jwnimmer-tri mentioned this issue May 8, 2020
Merged
@EricCousineau-TRI EricCousineau-TRI mentioned this issue May 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwnimmer-tri jwnimmer-tri

Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workspace: Remove dependency on ruby jwnimmer-tri/drake
2 participants
@jwnimmer-tri @EricCousineau-TRI