Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserLoginFailure log username in SubjectId column instead of userid #6

Open
BerDuc opened this issue Feb 9, 2023 · 0 comments
Open

Comments

@BerDuc
Copy link

BerDuc commented Feb 9, 2023

If you test a user login failure, in the AuditEntries table you will have the username both in the column SubjectIdentifier and in the column Subject. For all the other events I have a numerical identifier in the SubjectIdentifier column, so it feels weird having a username for the UserLoginFailure Event.
I searched why and found that in the UserLoginFailureEventAdapter, the line 16 look like this:
16 public ResourceActor Actor => new ResourceActor(ResourceActor.UserSubjectType, evt.Username, evt.Username);
It feels it is a mistake logging two times the Username. Is it by design? if so, why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant